-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction Factors #40
Conversation
…o output/ directory to avoid collision with lesson 02
… to seperate input and output paths'
…on into gh-pages Conflicts: 00-first-timers.md 01-starting-with-data.Rmd 01-starting-with-data.html 01-starting-with-data.md 01-supp-read-write-csv.md 02-func-R.Rmd 02-func-R.html 02-func-R.md 03-loops-R.html 03-loops-R.md 03-supp-loops-in-depth.html 03-supp-loops-in-depth.md 04-cond-colors-R.html 04-cond-colors-R.md 04-cond.Rmd 04-cond.html 04-cond.md 05-testing-R.md 06-best-practices-R.md 06-cmdline.html 06-cmdline.md 07-knitr-R.md 08-making-packages-R.md fig/01-starting-with-data-plot-avg-inflammation-1.png fig/01-starting-with-data-plot-max-inflammation-1.png fig/01-starting-with-data-plot-min-inflammation-1.png fig/02-func-R-rescale-test-1.png fig/02-func-R-rescale-test-2.png fig/03-loops-R-loop-analyze-4.png fig/03-loops-R-loop-analyze-5.png fig/03-loops-R-loop-analyze-6.png fig/03-loops-R-loop-analyze-7.png fig/03-loops-R-loop-analyze-8.png fig/03-loops-R-loop-analyze-9.png guide.md
Thanks for this PR, @tomwright01. It is quite an ambitious PR. You both change the data set and add extra sections. It may be different enough that we want to just create a new lesson set. Could you please provide a more detailed description of what you changed/added and your motivation for doing so? |
@jdblischak @tomwright01 What's the consensus - put this into one lesson, or have a separate lesson? |
We still haven't decided. Here's some more description from Tom on the r-discuss mailing list (post):
|
I quite like the change, but would be interested to see what feedback is from learners in the wild. |
Hi Scott, Feedback more directly related to the r-session included: Most feedback related to a capstone linking R and SQL. Speaking as the instructor I think the learners gained a pretty good grasp Perhaps the people assisting me in this lesson could add more insight? On Mon, Feb 23, 2015 at 7:06 PM, Scott Ritchie notifications@github.com
|
Hi Tom, That closely mirrors the feedback on a recent workshop I ran (using the materials at resbaz.github.io/r-novice-gapminder). We've had mixed results covering all the different data structures/types:
We've been considering skipping that material as a result, but leaving it as reference material for more advanced attendees (although personally I think Hadley Wickham's advanced R manual does them better justice). |
Thanks for the warning, and the hint. |
Yeah the materials I've written are designed to be run in a full-day (there's still too much material). That being said, we've (cc: @DamienIrving ) run several workshops in with the python-inflammation lessons, and they've taken us a full day to get through as well. |
My initial impression of this PR is that there is a ton of great material in here, including many of the improvements we have been talking about making for a long time, but that it also is too much material for a half-day session (perhaps even too much for a full day), and some of it is a bit too in-depth (IMO) for novices who have never seen R before. What are options for having this as exist on its own vs merged with the current versions? Or have a number of smaller pull requests that allow us to handle these additions/changes in chunks instead of all at once? What's the rule of thumb for the amount of content to be in or out of scope for novice SWC lessons? I think we should keep a simple set of lessons for true novices, and then have all the other great material we want to teach as either intermediate lessons or as a different 'flavor' of novice lessons. Not sure what best-practices are w/ regards to the above thoughts and the new organizational structure of SWC lessons. |
I agree with @naupaka the true novice lesson should be simpler. Unfortunately I don't think this PR can be split into smaller chunks, changing the dataset touches a lot of the lessons. After further experience with, and thought about, the r-novice and r-python lessons I think the scope of the lessons needs to be narrowed.
In this pull request I try to expand the scope of the lesson to also cover the strengths (vagaries) of R. As such it moves away from being language agnostic and should become a stand alone lesson. I suggest that we (I) try to restructure this lesson, removing the content that would be covered in the novice programming lesson. A novice workshop would then consist of:
|
Based on this discussion, my vote would be that these changes with a new data set would be best put in its own repository. As for making the current r-novice-inflammation lessons easier, there was a recent PR merged into python-novice-inflammation that, among other things, moved the part about the call stack to a supplementary lesson. I had previously sent out a message to r-discuss to see if there was any interest in implementing these changes. |
This PR introduces the concept of factors. This involved the use of a new example dataset Sites-.csv with variables suitable for interpretation as factors.
There is also more information on the different ways of addressing/slicing a dataframe, particularly logical indexing is introduced as this is very common.
All changes are to the Rmd files (except Sites-*.csv), the other files were generated by make.
This is my first sizable merge so apologies if I'm doing this wrong.