Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added location to save scripts for cmdline programs #460

Closed
wants to merge 1 commit into from

Conversation

MichaelBAnderson
Copy link

@MichaelBAnderson MichaelBAnderson commented Nov 11, 2019

Included the required information for where to save R scripts for command-line programming. Originally it simply said to save the files (without detailing where to save the files). This took me quiet a while to figure this out while preparing for demonstration so I hope it helps others.

Included the required information for where to save R scripts for command-line programming.  Originally it simply said to save the files (without detailing where to save the files).  This took me quiet a while to figure this out while preparing for demonstration so I hope it helps others.
@MichaelBAnderson MichaelBAnderson changed the title Updated 05-cmdline.Rmd Added location to save scripts for cmdline programs Nov 11, 2019
@HaoZeke
Copy link
Member

HaoZeke commented Nov 12, 2019

Hi @MichaelBAnderson, thanks for this. I will merge this after setting alternate instructions for the linux and mac users, and I will also have to check that there is no specific format followed for operating specific instructions. Thank you for taking the time to contribute and I will get back to you on this if other changes are required in a bit.

Base automatically changed from master to main March 17, 2021 23:59
@HaoZeke HaoZeke self-assigned this Apr 19, 2021
@HaoZeke HaoZeke added enhancement Enhancement to lesson material status:wait Progress dependent on another issue or conversation labels Apr 19, 2021
@zkamvar
Copy link
Contributor

zkamvar commented Apr 26, 2023

I'm helping the current lesson Maintainers process outstanding pull requests on this repository, in preparation for transition to the new lesson infrastructure.

Thank you for this contribution @MichaelBAnderson. I appreciate you providing a location to save the R script based on your experience, but I am afraid that this recommendation (saving scripts in the same directory as the R executable) is not good practice because the scripts may not be portable. Instead, it would be better for users to use RStudio or add R to their PATH. Because of this, I will be closing this PR without merging the change. I'm sorry for the delay in reviewing your contribution and hope that you will continue to contribute to The Carpentries lessons.

@zkamvar zkamvar closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to lesson material status:wait Progress dependent on another issue or conversation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants