Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link to regex lesson #1427

Open
maneesha opened this issue Aug 4, 2023 · 6 comments
Open

Broken link to regex lesson #1427

maneesha opened this issue Aug 4, 2023 · 6 comments
Labels
status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR

Comments

@maneesha
Copy link
Contributor

maneesha commented Aug 4, 2023

The wildcards section includes a broken link to an old regex lesson.

@zkamvar
Copy link
Contributor

zkamvar commented Aug 7, 2023

Note for maintainers: It might be better to remove the reference all together unless we have an equivalent "advanced regexp" that we can point to. The subdomain is v4, which existed between 2010 and 2012.

The earliest internet archive snapshot is from 2016 and contains several broken images and links.

@deppen8
Copy link
Contributor

deppen8 commented Aug 7, 2023

Perhaps we could replace it with a link to this lesson in the Incubator:
https://carpentries-incubator.github.io/regex-novice-biology/

@bkmgit
Copy link
Contributor

bkmgit commented Aug 8, 2023

Timings not yet added to the biology lesson, but it does seem helpful.

Maybe the manual is also worth pointing out:
https://www.gnu.org/software/grep/manual/grep.html
https://www.gnu.org/software/grep/manual/html_node/Regular-Expressions.html

May also want to reference ugrep as some people may need additional features such as unicode support.

@gcapes
Copy link
Contributor

gcapes commented Jan 31, 2024

I just checked and the link in that section link looks to be working. I guess we can now close this issue, and #1431?

@gcapes gcapes added the status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR label Jan 31, 2024
@bkmgit
Copy link
Contributor

bkmgit commented Feb 7, 2024

Closed the pull request. Maybe helpful to update the text to indicate it points to library carpentry so people are not surprised. There is a related issue for the references section #1451

@maneesha
Copy link
Contributor Author

maneesha commented Feb 7, 2024

It is a valid link now - it was fixed with #1438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR
Projects
None yet
Development

No branches or pull requests

5 participants