Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar Mistake in "07-find.md" at "Matching and Subtracting" solution. #1437

Closed
ghost opened this issue Sep 27, 2023 · 0 comments · Fixed by #1440
Closed

Grammar Mistake in "07-find.md" at "Matching and Subtracting" solution. #1437

ghost opened this issue Sep 27, 2023 · 0 comments · Fixed by #1440
Labels
good first issue Good issue for first-time contributors type:clarification Suggest change to make lesson clearer

Comments

@ghost
Copy link

ghost commented Sep 27, 2023 •
edited by ghost
Loading

What is the problem?

In the solution of the "Matching and Subtracting" exercise the following line can be found:

"Option 2 is also works in this instance because the shell tries to expand...."

While English is not my native language, I am pretty sure it should be either "Option 2 is correct..." or "Option 2 also works...". I suspect the author wanted to avoid repeating the wording of Option 1 and decided to do a last minute change.

Thanks for all your work. Wonderful tutorial by the way.

Location of problem (optional)

episodes/07-find.md
@gcapes gcapes added type:clarification Suggest change to make lesson clearer good first issue Good issue for first-time contributors labels Sep 28, 2023
@392781 392781 mentioned this issue Nov 8, 2023
Merged
bkmgit added a commit that referenced this issue Nov 9, 2023
@bkmgit
Merge pull request #1440 from 392781/main
5bf3172 
Fixed grammatical typos (#1437)
github-actions bot pushed a commit that referenced this issue Nov 9, 2023
@actions-user
markdown source builds
dbf3517 
Auto-generated via {sandpaper}
Source  : 5bf3172
Branch  : main
Author  : Benson Muite <bkmgit@users.noreply.github.com>
Time    : 2023-11-09 06:24:56 +0000
Message : Merge pull request #1440 from 392781/main

Fixed grammatical typos (#1437)
github-actions bot pushed a commit that referenced this issue Nov 9, 2023
@actions-user
site deploy
5547c16 
Auto-generated via {sandpaper}
Source  : dbf3517
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-11-09 06:28:11 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5bf3172
Branch  : main
Author  : Benson Muite <bkmgit@users.noreply.github.com>
Time    : 2023-11-09 06:24:56 +0000
Message : Merge pull request #1440 from 392781/main

Fixed grammatical typos (#1437)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for first-time contributors type:clarification Suggest change to make lesson clearer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed grammatical typos (#1437)
1 participant
@gcapes