Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ISSUE-600: data-shell/data/animals.txt is truncated #722
Added additional records to bring the animals.txt file up to 586 lines as mentioned in the text. Added ellipses to the file listing to indicate more data exists in the file than listed.
Before the change, checked the output of the example
Added additional records and checked the distribution of values
[arne@localhost data]$ cat animals.txt | sort | uniq -c
Tested the example pipeline to ensure no changes resulted
I'm personally fine with either fix (increasing the file size to match the existing lesson text, or changing the lesson text to match the existing file size). However the former has the advantage that we have a pull request that implements it (right here), and the latter is hypothetical.
Is there a downside to merging this? It seems like a strict improvement over the current state of the lesson.