Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WordlistEndpoint #20

Merged
merged 2 commits into from
Jun 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ client.entry_antonyms_synonyms('monotonous')
# Inflections of a word
inflections = client.inflection('changed')

# Wordlist results (based on categorys, filters, etc...)
related = client.wordlist(lexicalCategory: 'Noun', word_length: '>5,<10')

# Or the search endpoint
search_results = client.search('condition', prefix: true)
```
Expand All @@ -85,10 +82,6 @@ filters = { lang: 'es' }

# To use multiple values on a single filter, make it an array
filters = { lexicalCategory: ['Noun', 'Verb'] }

# The wordlist endpoint specifically may include "nested" filters
# These filters (exclude, exclude_senses, etc...) require arrays
filters = { exclude: [domains: %w(sport art)] }
```

Argument names need to be in camelCase, not snake_case. However, the objects returned from API calls use snake_case attributes.
Expand Down
2 changes: 0 additions & 2 deletions lib/oxford_dictionary/client.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
require 'oxford_dictionary/endpoints/entry_endpoint'
require 'oxford_dictionary/endpoints/inflection_endpoint'
require 'oxford_dictionary/endpoints/search_endpoint'
require 'oxford_dictionary/endpoints/wordlist_endpoint'

require 'oxford_dictionary/endpoints/entries'
require 'oxford_dictionary/endpoints/lemmas'
Expand All @@ -18,7 +17,6 @@ class Client
include OxfordDictionary::Endpoints::EntryEndpoint
include OxfordDictionary::Endpoints::InflectionEndpoint
include OxfordDictionary::Endpoints::SearchEndpoint
include OxfordDictionary::Endpoints::WordlistEndpoint

attr_reader :app_id, :app_key

Expand Down
35 changes: 0 additions & 35 deletions lib/oxford_dictionary/endpoints/wordlist_endpoint.rb

This file was deleted.

69 changes: 0 additions & 69 deletions spec/endpoint_specs/wordlist_endpoint_spec.rb

This file was deleted.

77 changes: 0 additions & 77 deletions spec/fixtures/wordlist_complex.json

This file was deleted.

65 changes: 0 additions & 65 deletions spec/fixtures/wordlist_goal_advanced.json

This file was deleted.

23 changes: 0 additions & 23 deletions spec/fixtures/wordlist_rare_art.json

This file was deleted.