Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite in es5 JavaScript to work in older RStudio #3

Closed
timelyportfolio opened this issue Jul 19, 2019 · 1 comment
Closed

rewrite in es5 JavaScript to work in older RStudio #3

timelyportfolio opened this issue Jul 19, 2019 · 1 comment

Comments

@timelyportfolio
Copy link
Contributor

Great work, I saw jExcel and hoped someone would make it into an htmlwidget. I hope you don't mind me barging in without any permission, but I couldn't find any way to contact you.

RStudio viewer did not become modern until very recently, which means many users of older versions of RStudio will not be able to use excelR.

I will submit a pull rewriting JavaScript in ancient form :)

If you agree this is a good thing, then please review that I didn't miss anything. The only real question I had was on style. I could not find this argument listed in the jExcel docs so I could not test.

Thanks!!!!

@Swechhya
Copy link
Owner

@timelyportfolio I certainly agree with you on this. I did not realize that it was only recently that RStudio viewer started using es6. Also, the package uses jexcel v3 and not v2 and table styling has been documented here. Thank you for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants