Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to resolve multiple issues #6

Merged
merged 10 commits into from
Jul 20, 2019
Merged

Conversation

timelyportfolio
Copy link
Contributor

I was so excited to see on Twitter that you wrapped jExcel as an htmlwidget. You did a great job, but as I played a little bit, I discovered a couple issues. Sorry to wrap this in one pull request and assume that all of my concerns are valid. Please let me know if easier to separate these out into multiple smaller isolated pulls.

List of changes:

  1. Add NEWS.md to track changes in future versions and start a notification of the changes in this pull request.
  2. Rewrite JavaScript in old form to work with older RStudio versions timelyportfolio@89efcb8 rewrite in es5 JavaScript to work in older RStudio #3
  3. Allow passing of many logical arguments to the widget if FALSE timelyportfolio@7eee384 pass logical arguments to widget #4
  4. Add more examples timelyportfolio@3d50cce
  5. Begin to add tests timelyportfolio@2d49af5 test package #5

DESCRIPTION Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/jexcel.R Show resolved Hide resolved
inst/htmlwidgets/jexcel.js Outdated Show resolved Hide resolved
@Swechhya Swechhya merged commit 3ba31ca into Swechhya:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants