Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override or disable the default logo in the header #207

Closed
theseal opened this issue Oct 31, 2023 · 3 comments
Closed

Override or disable the default logo in the header #207

theseal opened this issue Oct 31, 2023 · 3 comments
Assignees
@oestrogen @felix-hellman
Labels
bug Something isn't working

Comments

@theseal
Copy link
Contributor

theseal commented Oct 31, 2023 •
edited
Loading

The default logo (Sweden Connect) flashes by before the SPs logo is loaded. Is it possible to disable the default header logo or at-least override it?

Feels a little bit phishy to have a logo/image that changes during an login flow.
@martin-lindstrom martin-lindstrom added the bug Something isn't working label Oct 31, 2023
@martin-lindstrom
Copy link
Member

martin-lindstrom commented Oct 31, 2023 •
edited
Loading

Very odd. We will look into that. There shouldn’t be a default logo.

@theseal
Copy link
Contributor Author

theseal commented Oct 31, 2023

Not sure how Vue works but this might be it?
https://github.com/swedenconnect/bankid-saml-idp/blob/b1f48df46911fab2c9ce290221aea48838bf29c5/bankid-frontend/src/components/AppHeader.vue#L15C1-L16

@oestrogen oestrogen mentioned this issue Nov 1, 2023
Merged
@martin-lindstrom
Copy link
Member

Fixed in #210. Merged to fixbranch-1.1. Will be included in 1.1.1 release.

@martin-lindstrom martin-lindstrom mentioned this issue Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oestrogen oestrogen

@felix-hellman felix-hellman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oestrogen @theseal @felix-hellman @martin-lindstrom