-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweep: Rename the Decimal
type to Float
?
#1
Comments
Here's the PR! #6.💎 Sweep Pro: I used GPT-4 to create this ticket. You have 1041 GPT-4 tickets left.
Step 1: 🔍 Code SearchI found the following snippets in your repository. I will now analyze these snippets and come up with a plan. Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.enso/docs/semantics/numbers.md Lines 1 to 66 in 828d160
enso/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Numbers.enso Lines 331 to 513 in 828d160
enso/distribution/lib/Standard/Base/0.0.0-dev/src/Data/Numbers.enso Lines 592 to 697 in 828d160
Lines 1 to 88 in 828d160
enso/engine/runtime/src/test/scala/org/enso/compiler/test/semantic/ImportExportTest.scala Lines 185 to 256 in 828d160
Step 2: 🧐 Snippet AnalysisFrom looking through the relevant snippets, I decided to make the following modifications:
Step 3: 📝 PlanningI have created a plan for writing the pull request. I am now working my plan and coding the required changes to address this issue. Here is the planned pull request: Rename
Step 4: ⌨️ CodingI have finished coding the issue. I am now reviewing it for completeness. Step 5: 🔁 Code ReviewSuccess! 🚀 I'm a bot that handles simple bugs and feature requests but I might make mistakes. Please be kind! |
Discussed in https://github.com/orgs/enso-org/discussions/6858
Originally posted by radeusgd May 25, 2023
The discussion on enso-org#6817 showed that our number type names and
Value_Type
are misaligned:As discussed, we decided that we want to rename the
Decimal
type toFloat
.Decimal
type in Enso code intoFloat
.Decimal
type name in the Java engine code.ToDecimalNode
should now beToFloatNode
, thedecimal
packages should be renamed tofloat
etc.The text was updated successfully, but these errors were encountered: