Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fireworks particles on click to the pricing page #516

Closed
wants to merge 5 commits into from

Conversation

sweep-nightly[bot]
Copy link
Contributor

@sweep-nightly sweep-nightly bot commented Sep 29, 2023

Description

This PR adds the feature to display fireworks particles on click to the pricing page. It includes the installation of the "tsparticles-preset-fireworks" package and the necessary modifications to the PricingPage component.

Summary of Changes

  • Added the "tsparticles-preset-fireworks" package to the project dependencies.
  • Imported the necessary modules in the PricingPage component.
  • Initialized tsParticles and loaded the "Fireworks" preset in the PricingPage component.
  • Added an event listener to the pricing page element to trigger the fireworks particles on click.

Please review and merge these changes to enable the fireworks particles on the pricing page.

Fixes #509.


🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

  • Leave a comment below to get Sweep to edit the entire PR
  • Leave a comment in the code will only modify the file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly sweep-nightly bot added the sweep label Sep 29, 2023
@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for papaya-pothos-8db6ca failed.

Name Link
🔨 Latest commit acdc88e
🔍 Latest deploy log https://app.netlify.com/sites/papaya-pothos-8db6ca/deploys/651632d96a7b790008a93985

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for sweepdev failed.

Name Link
🔨 Latest commit acdc88e
🔍 Latest deploy log https://app.netlify.com/sites/sweepdev/deploys/651632d9b5c2160008f455a2

@sweep-nightly
Copy link
Contributor Author

sweep-nightly bot commented Sep 29, 2023

GitHub actions yielded the following error.

##[error]src/components/PricingPage.tsx(4,37): error TS2307: Cannot find module 'tsparticles-preset-fireworks' or its corresponding type declarations.
##[error]src/components/PricingPage.tsx(14,5): error TS18047: 'pricingPage' is possibly 'null'.
##[error]src/components/PricingPage.tsx(15,25): error TS2339: Property 'fireworks' does not exist on type 'Container[]'.
error Command failed with exit code 2.

The command that failed is yarn run tsc.

This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests.

@sweep-nightly
Copy link
Contributor Author

sweep-nightly bot commented Sep 29, 2023

🚀 Wrote Changes

##[error]src/components/PricingPage.tsx(4,37): error TS2307: Cannot find module 'tsparticles-preset-fireworks' or its corresponding type declarations.
##[error]src/components/PricingPage.tsx(14,5): error TS18047: 'pricingPage' is possibly 'null'.
##[error]src/components/PricingPage.tsx(15,25): error TS2339: Property 'fireworks' does not exist on type 'Container[]'.
error Command failed with exit code 2.

The command that failed is yarn run tsc.

Hi @sweep-nightly[bot],

I decided to make the following changes:

File Path Proposed Changes
src/components/PricingPage.tsx Modify src/components/PricingPage.tsx with contents:
• Install the "tsparticles-preset-fireworks" package using npm or yarn.
• Import the "tsparticles-preset-fireworks" package at the top of the file.
• Inside the useEffect hook, check if the "pricingPage" variable is not null before adding an event listener to it.
• Replace the line "tsParticles.dom().fireworks.start();" with "tsParticles.dom().start();".

Contact us
</Button>
</Box>
// Rest of the code...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change

Copy link
Contributor Author

@sweep-nightly sweep-nightly bot Sep 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sweep-nightly
Copy link
Contributor Author

sweep-nightly bot commented Sep 29, 2023

GitHub actions yielded the following error.

##[error]src/components/PricingPage.tsx(4,37): error TS2307: Cannot find module 'tsparticles-preset-fireworks' or its corresponding type declarations.
##[error]src/components/PricingPage.tsx(16,27): error TS2339: Property 'start' does not exist on type 'Container[]'.
error Command failed with exit code 2.

The command that failed is yarn run tsc.

This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests.

@sweep-nightly
Copy link
Contributor Author

sweep-nightly bot commented Sep 29, 2023

🚀 Wrote Changes

##[error]src/components/PricingPage.tsx(4,37): error TS2307: Cannot find module 'tsparticles-preset-fireworks' or its corresponding type declarations.
##[error]src/components/PricingPage.tsx(16,27): error TS2339: Property 'start' does not exist on type 'Container[]'.
error Command failed with exit code 2.

The command that failed is yarn run tsc.

Hi @sweep-nightly[bot],

I decided to make the following changes:

File Path Proposed Changes
src/components/PricingPage.tsx Modify src/components/PricingPage.tsx with contents:
• Install the "tsparticles-preset-fireworks" module using npm or yarn.
• Import the tsParticles library and the "Fireworks" preset at the top of the file.
• Initialize the tsParticles library and load the "Fireworks" preset in the PricingPage component.
• Add an event listener to the pricing page element to trigger the fireworks particles on click.

@sweep-nightly sweep-nightly bot closed this Sep 30, 2023
@sweep-nightly sweep-nightly bot deleted the sweep/fireworks-particles branch September 30, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: Add fireworks particles on click to the pricing page
1 participant