Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigating to previous page keeps sweet alert open #54

Closed
brampeirs opened this issue Feb 14, 2018 · 2 comments
Closed

Navigating to previous page keeps sweet alert open #54

brampeirs opened this issue Feb 14, 2018 · 2 comments

Comments

@brampeirs
Copy link

The alert doen't close when navigating to a previous page (when using prev keys).
toverux added a commit that referenced this issue Feb 14, 2018
@toverux
feat(SwalComponent): close a sweet alert when the SwalComponent that …
2af800a 
…created it is detroyed (#54)
@toverux
Copy link
Member

toverux commented Feb 14, 2018

Hello @brampeirs, I think your problem may be fixed by the latest version (see below). Now, a currently-displayed SweetAlert will be closed if the <swal> component that created it is destroyed by Angular.
Please upgrade and tell me if you still have the problem (then I may need more informations / repro code).

3.3.0 (2018-02-14)

Features

  • SwalComponent: close a sweet alert when the SwalComponent that created it is detroyed (#54) (2af800a)

@toverux toverux closed this as completed Feb 20, 2018
@brampeirs
Copy link
Author

Updating solved the problem, thank you.

limonte pushed a commit that referenced this issue Nov 6, 2022
@toverux
feat(SwalComponent): close a sweet alert when the SwalComponent that …
a2d608f 
…created it is detroyed (#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toverux @brampeirs