fix: improve toasts styles

sweetalert2 · Sep 19, 2021 · afb7942 · afb7942
1 parent f4ecd99
commit afb7942
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/src/instanceMethods/buttons-handlers.js b/src/instanceMethods/buttons-handlers.js
@@ -100,7 +100,7 @@ const confirm = (instance, value) => {
   const innerParams = privateProps.innerParams.get(instance || this)
 
   if (innerParams.showLoaderOnConfirm) {
-    showLoading() // TODO: make showLoading an *instance* method
+    showLoading()
   }
 
   if (innerParams.preConfirm) {

diff --git a/src/scss/_toasts.scss b/src/scss/_toasts.scss
@@ -114,8 +114,8 @@
       justify-content: flex-start;
       height: auto;
       margin: 0;
-      margin-top: .3125em;
-      padding: 0;
+      margin-top: .5em;
+      padding: 0 .5em;
     }
 
     .swal2-styled {

diff --git a/src/staticMethods/bindClickHandler.js b/src/staticMethods/bindClickHandler.js
@@ -11,7 +11,6 @@ export function bindClickHandler (attr = 'data-swal-template') {
 }
 
 const bodyClickListener = (event) => {
-  // TODO: replace with event.composedPath()
   for (let el = event.target; el && el !== document; el = el.parentNode) {
     for (const attr in clickHandlers) {
       const template = el.getAttribute(attr)

diff --git a/src/variables.scss b/src/variables.scss
@@ -234,11 +234,11 @@ $swal2-toast-close-button-margin: 0 !default;
 $swal2-toast-close-button-font-size: 2em !default;
 $swal2-toast-width: 360px !default;
 $swal2-toast-padding: 1em !default;
-$swal2-toast-title-margin: 1em !default;
+$swal2-toast-title-margin: .5em 1em !default;
 $swal2-toast-title-padding: 0 !default;
 $swal2-toast-title-font-size: 1em !default;
 $swal2-toast-icon-font-size: 1.8em !default;
-$swal2-toast-html-container-margin: 1em !default;
+$swal2-toast-html-container-margin: .5em 1em !default;
 $swal2-toast-html-container-padding: 0 !default;
 $swal2-toast-html-container-font-size: 1em !default;
 $swal2-toast-input-height: 2em !default;