fix: enable buttons in hideLoading (#2048)

sweetalert2 · Sep 7, 2020 · e34dc30 · e34dc30
1 parent 8190f31
commit e34dc30
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/cypress/integration/methods/input.spec.js b/cypress/integration/methods/input.spec.js
@@ -377,6 +377,9 @@ describe('Validation', () => {
     Swal.getInput().value = 'blah-blah'
     Swal.clickConfirm()
     setTimeout(() => {
+      expect(Swal.getConfirmButton().disabled).to.be.false
+      expect(Swal.getDenyButton().disabled).to.be.false
+      expect(Swal.getCancelButton().disabled).to.be.false
       expect(isVisible(Swal.getValidationMessage())).to.be.true
       expect(Swal.getValidationMessage().textContent).to.equal('Invalid phone number')
       Swal.getInput().value = '123-456-7890'

diff --git a/src/instanceMethods/hideLoading.js b/src/instanceMethods/hideLoading.js
@@ -21,6 +21,9 @@ function hideLoading () {
   dom.removeClass([domCache.popup, domCache.actions], swalClasses.loading)
   domCache.popup.removeAttribute('aria-busy')
   domCache.popup.removeAttribute('data-loading')
+  domCache.confirmButton.disabled = false
+  domCache.denyButton.disabled = false
+  domCache.cancelButton.disabled = false
 }
 
 export {

diff --git a/test/qunit/validation.js b/test/qunit/validation.js
@@ -18,6 +18,9 @@ QUnit.test('input.checkValidity()', (assert) => {
   Swal.getInput().value = 'blah-blah'
   Swal.clickConfirm()
   setTimeout(() => {
+    assert.notOk(Swal.getConfirmButton().disabled)
+    assert.notOk(Swal.getDenyButton().disabled)
+    assert.notOk(Swal.getCancelButton().disabled)
     assert.ok(isVisible(Swal.getValidationMessage()))
     assert.equal(Swal.getValidationMessage().textContent, 'Invalid phone number')