fix(inputValue): warn about invalid inputValue

src/instanceMethods/_main.js

@@ -2,7 +2,7 @@ import defaultParams, { showWarningsForParams } from '../utils/params'
 import * as dom from '../utils/dom/index'
 import { swalClasses } from '../utils/classes'
 import Timer from '../utils/Timer'
-import { formatInputOptions, error, callIfFunction, isThenable } from '../utils/utils'
+import { formatInputOptions, error, warn, callIfFunction, isThenable } from '../utils/utils'
 import setParameters from '../utils/setParameters'
 import globalState from '../globalState'
 import { openPopup } from '../utils/openPopup'
@@ -417,7 +417,11 @@ export function _main (userParams) {
       case 'tel':
       case 'url': {
         input = dom.getChildByClass(domCache.content, swalClasses.input)
-        input.value = innerParams.inputValue
+        if (typeof innerParams.inputValue === 'string' || typeof innerParams.inputValue === 'number') {
+          input.value = innerParams.inputValue
+        } else {
+          warn(`Unexpected type of inputValue! Expected "string" or "number", got "${typeof innerParams.inputValue}"`)
+        }
         input.placeholder = innerParams.inputPlaceholder
         input.type = innerParams.input
         dom.show(input)

src/utils/utils.js

@@ -79,4 +79,4 @@ export const warnOnce = (message) => {
  */
 export const callIfFunction = (arg) => typeof arg === 'function' ? arg() : arg
 
-export const isThenable = (arg) => typeof arg === 'object' && typeof arg.then === 'function'
+export const isThenable = (arg) => arg && typeof arg === 'object' && typeof arg.then === 'function'

test/qunit/params/inputValue.js

@@ -0,0 +1,37 @@
+const { Swal, SwalWithoutAnimation, TIMEOUT } = require('../helpers')
+const sinon = require('sinon/pkg/sinon')
+
+QUnit.test('inputValue number', (assert) => {
+  Swal({ input: 'text', inputValue: 333 })
+  assert.ok(Swal.getInput().value, '333')
+})
+
+QUnit.test('inputValue as a Promise', (assert) => {
+  const inputTypes = ['text', 'email', 'number', 'tel', 'textarea']
+  const done = assert.async(inputTypes.length)
+  const value = '1.1 input value'
+  const inputValue = new Promise((resolve) => {
+    resolve('1.1 input value')
+  })
+  inputTypes.forEach(input => {
+    SwalWithoutAnimation({
+      input,
+      inputValue,
+      onOpen: (modal) => {
+        setTimeout(() => {
+          const inputEl = input === 'textarea' ? modal.querySelector('.swal2-textarea') : modal.querySelector('.swal2-input')
+          assert.equal(inputEl.value, input === 'number' ? parseFloat(value) : value)
+          done()
+        }, TIMEOUT)
+      }
+    })
+  })
+})
+
+QUnit.test('should throw console warning about unexpected type of inputValue', (assert) => {
+  const _consoleWarn = console.warn
+  const spy = sinon.spy(console, 'warn')
+  Swal({ input: 'text', inputValue: undefined })
+  console.warn = _consoleWarn
+  assert.ok(spy.calledWith('SweetAlert2: Unexpected type of inputValue! Expected "string" or "number", got "undefined"'))
+})

test/qunit/tests.js

@@ -790,25 +790,3 @@ QUnit.test('Custom content', (assert) => {
     done()
   })
 })
-
-QUnit.test('inputValue as a Promise', (assert) => {
-  const inputTypes = ['text', 'email', 'number', 'tel', 'textarea']
-  const done = assert.async(inputTypes.length)
-  const value = '1.1 input value'
-  const inputValue = new Promise((resolve) => {
-    resolve('1.1 input value')
-  })
-  inputTypes.forEach(input => {
-    SwalWithoutAnimation({
-      input,
-      inputValue,
-      onOpen: (modal) => {
-        setTimeout(() => {
-          const inputEl = input === 'textarea' ? modal.querySelector('.swal2-textarea') : modal.querySelector('.swal2-input')
-          assert.equal(inputEl.value, input === 'number' ? parseFloat(value) : value)
-          done()
-        }, TIMEOUT)
-      }
-    })
-  })
-})