Feature: add ability to provide input label
#2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limonte
requested changes
Oct 11, 2020
There was a problem hiding this comment.
AMAZING AMAZING AMAZING contribution, thank you @krosenk729!
Please make some changes according to the review.
|
thanks for the fast review @limonte - everything should be updated |
limonte
approved these changes
Oct 11, 2020
There was a problem hiding this comment.
Thanks a lot @krosenk729
This feature will definitely improve the plugin's a11y!
Will be released in 1 hour or so.
limonte
pushed a commit
that referenced
this pull request
Oct 11, 2020
# [10.4.0](v10.3.7...v10.4.0) (2020-10-11) ### Features * add `inputLabel` parameter ([#2078](#2078)) ([a437376](a437376))
|
🎉 This PR is included in version 10.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
matvejs16
pushed a commit
to matvejs16/sweetalert2-fix
that referenced
this pull request
Mar 29, 2023
* adding ability to add 'label' element to inputs * updating label to 'input-label'
matvejs16
pushed a commit
to matvejs16/sweetalert2-fix
that referenced
this pull request
Mar 29, 2023
# [10.4.0](sweetalert2/sweetalert2@v10.3.7...v10.4.0) (2020-10-11) ### Features * add `inputLabel` parameter ([sweetalert2#2078](sweetalert2#2078)) ([0c8c938](sweetalert2@0c8c938))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows someone to provide
inputLabelwhich will create a element linked to the input (this is a significant improvement to accessibility)