Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Type Definition #2411

Closed
graphemecluster opened this issue Feb 27, 2022 · 2 comments
Closed

Incorrect Type Definition #2411

graphemecluster opened this issue Feb 27, 2022 · 2 comments
Labels
released

Comments

@graphemecluster
Copy link

https://github.com/sweetalert2/sweetalert2/blob/master/sweetalert2.d.ts#L679

A custom CSS class for the popup.
If a string value is provided, the classname will be applied to the popup.
If an object is provided, the classnames will be applied to the corresponding fields:

- customClass?: SweetAlertCustomClass
+ customClass?: SweetAlertCustomClass | string
@rsrinivasan1
Copy link

Hi, I can try to resolve this as my first issue.

github-actions bot pushed a commit that referenced this issue Mar 19, 2022
@semantic-release-bot
chore(release): 11.4.6 [skip ci]
7c06ac6 
## [11.4.6](v11.4.5...v11.4.6) (2022-03-19)

### Bug Fixes

* **types:** customClass can be also a string ([27e9282](27e9282)), closes [#2411](#2411)
@limonte
Copy link
Member

limonte commented Mar 19, 2022

🎉 This issue has been resolved in version 11.4.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

matvejs16 pushed a commit to matvejs16/sweetalert2-fix that referenced this issue Mar 29, 2023
@limonte
fix(types): customClass can be also a string
c23cc0d 
fixes sweetalert2#2411
matvejs16 pushed a commit to matvejs16/sweetalert2-fix that referenced this issue Mar 29, 2023
@semantic-release-bot
chore(release): 11.4.6 [skip ci]
8cc062b 
## [11.4.6](sweetalert2/sweetalert2@v11.4.5...v11.4.6) (2022-03-19)

### Bug Fixes

* **types:** customClass can be also a string ([c23cc0d](sweetalert2@c23cc0d)), closes [sweetalert2#2411](sweetalert2#2411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@limonte @rsrinivasan1 @graphemecluster