Refactor/extract static methods #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module into staticMethods/misc.js
…ds from main module
…seModal, closeToast) from main module
zenflow
added
domain: devel
|
Love the commit history. This is the first time I'm thinking that by doing 'Squash and merge' I'm harming the commit history which is, in theory, the powerful tool but in practice quite often just a mess. |
|
@zenflow what do you think about re-enabling the "Rebase and merge" option? |
|
@limonte I really just wrote the clean commit history for review purposes. I think that amount of granularity in the |
|
Gotcha, done 👍 |
This was referenced Mar 20, 2018
|
Released in v7.17.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #970
Moves all "static methods" ("static" in the sense of methods of the "constructor", but excluding the ones depending on our "current instance" or
currentContext) into modules insrc/staticMethods/.