Reduce method complexity of setParameters()

[gverni]

Created two functions:

• setDefaultInputValidators(): to assign default input validators
• validateCustomTargetElement(): to check if the target element is a valid one

Also:

• Moved warning message to a constant outside of function
• Code clean-up

Fix #1490

[gverni]

Codeclimate integration reports only 1 issue fixed ("Function setParameters has 34 lines of code (exceeds 25 allowed). Consider refactoring."). I'm checking about method complexity.

[coveralls]

Pull Request Test Coverage Report for Build 5068

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 13 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.02%) to 90.656%

---

Files with Coverage Reduction	New Missed Lines	%
dist/sweetalert2.js	13	90.66%

Totals
Change from base Build 5061:	0.02%
Covered Lines:	1256
Relevant Lines:	1331

---

💛 - Coveralls

[gverni]

In 8e989d2 I removed the if statement at the end of the setParameters() function. The reason is that the condition:

sweetalert2/src/utils/setParameters.js

Lines 54 to 56 in 801edf0

	!oldPopup ||
	// If the model target has changed, refresh the popup
	(oldPopup && targetElement && oldPopup.parentNode !== targetElement.parentNode)

always returned true (or I didn't understand the logic). In fact oldPopup.parentNode is the Swal2 container (i.e. swal2-container). The only condition when this condition is true is if the targetElement is actually the popup itself.... which is a use case I cannot think of.

Replacing the right side of the OR with a more correct:

oldPopup.parentNode.parentNode !== targetElement

makes 11 test fail:

✗ toast aria attributes
✗ grow fullscreen
✗ Modal positions
✗ Toast positions
✗ Toast positions with target
✗ should throw console error about invalid type
✗ container should have .swal2-rtl in case of
✗ container should have .swal2-rtl in case of
✗ should show the popup with OK button in case of empty object passed as an argument
✗ JS element as html param
✗ onBeforeOpen

I can analyze why the above fails (likely cause is that the dom is not updated unless the target element is different), but before doing so, @limonte @zenflow do you agree with my analysis that that condition is always true? Or is there some obscure use case that I cannot think of that needs that check?

[limonte]

I can analyze why the above fails (likely cause is that the dom is not updated unless the target element is different), but before doing so, do you agree with my analysis that that condition is always true? Or is there some obscure use case that I cannot think of that needs that check?

This is the leftover from the previous versions when we were reusing the same DOM node for all popups. Now we're creating the new DOM node (.swal2-container) for each popup.

[limonte]

Thank you @gverni!

I reverted the loaderOnConfirmMessage variable, other than that all is good 🚀

[limonte]

🎉 This PR is included in version 8.13.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀