Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulp-eslint to the latest version 馃殌 #1639

Closed
wants to merge 4 commits into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jun 28, 2019

The devDependency gulp-eslint was updated from 5.0.0 to 6.0.0.

This version is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Release Notes for v6.0.0

v5.0.0...v6.0.0

Commits

The new version differs by 2 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 馃尨

@gverni
Copy link
Contributor

gverni commented Jul 2, 2019

The errors in travis-ci are caused by upgrade to ESLint 6.0:

/home/travis/build/[secure]/[secure]/src/utils/params.js
  121:24  error  Do not access Object.prototype method 'hasOwnProperty' from target object  no-prototype-builtins

and

/home/travis/build/[secure]/[secure]/src/utils/dom/animationEndEvent.js
  17:28  error  Do not access Object.prototype method 'hasOwnProperty' from target object  no-prototype-builtins

caused by eslint:recommended has been updated

/home/travis/build/[secure]/[secure]/test/qunit/helpers.js
  1:11  error  'CustomEvent' is already defined as a built-in global variable  no-redeclare

caused by The no-redeclare rule is now more strict by default

In ESlint 6.0 eslint:recommended has been updated adding
no-prototype-builtins. See more at
https://eslint.org/docs/user-guide/migrating-to-6.0.0#-eslintrecommended-has-been-updated
In ESlint 6.0 the  `no-redeclare` rule will now report an error for
globals enabled by comments. See more at
https://eslint.org/docs/user-guide/migrating-to-6.0.0#no-redeclare-updates
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5082

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.634%

Totals Coverage Status
Change from base Build 5071: 0.0%
Covered Lines: 1254
Relevant Lines: 1329

馃挍 - Coveralls

@gverni
Copy link
Contributor

gverni commented Jul 2, 2019

Ready to be merged @limonte if you want.

I checked the two hasOwnProperty changes and they looked good (i.e. same behaviour as before). This may require to update the settings for the ESlint version in your IDE / extension to keep them aligned.

@greenkeeper greenkeeper bot closed this Jul 4, 2019
@greenkeeper greenkeeper bot deleted the greenkeeper/gulp-eslint-6.0.0 branch July 4, 2019 10:31
@limonte
Copy link
Member

limonte commented Jul 4, 2019

Oops, totally missed this PR, sorry @gverni!

@limonte
Copy link
Member

limonte commented Jul 4, 2019

@gverni cherry-picked your commits to the master branch, all is well now, thank you 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants