Fix complexity of close method

[JulianoGTZ]

Separate some responsibilities relative to animation on the close method.

Fixes #1531

[coveralls]

Pull Request Test Coverage Report for Build 5098

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 13 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.02%) to 90.914%

---

Files with Coverage Reduction	New Missed Lines	%
dist/sweetalert2.js	13	90.91%

Totals
Change from base Build 5095:	0.02%
Covered Lines:	1263
Relevant Lines:	1333

---

💛 - Coveralls

[limonte]

Thank you @JulianoGTZ

A few small changes before merging

[limonte]

Thank you @JulianoGTZ!

[gverni]

Thanks @JulianoGTZ for your help! For the future you may want to install some plugin in your IDE for highlighting linting/formatting errors. I've found few empty lines an extra spaces scattered around your code. I personally use StandardJS and its VSC plugin.

@limonte I'm going to adjust those in my next PR to fix #1640

[limonte]

As per email agreement with @JulianoGTZ I just sent the invitation to become SweetAlert2's collaborator. Welcome aboard @JulianoGTZ 🍻

Also, @gverni I granted you the owner permissions to the org, if a bus-factor will happen to me, I believe you'll not allow SweetAlert2 to fade away.

---

As to formatting rules, we should add those rules about spaces to our eslint config to enforce the coding style. @gverni I believe this one is what you're talking about https://eslint.org/docs/rules/space-in-parens

[limonte]

As to formatting rules, we should add those rules about spaces to our eslint config to enforce the coding style. @gverni I believe this one is what you're talking about https://eslint.org/docs/rules/space-in-parens

Done in 80e04f0

cc @gverni

[gverni]

Done in 80e04f0

Thanks @limonte! It was exactly that...

Also, @gverni I granted you the owner permissions to the org, if a bus-factor will happen to me, I believe you'll not allow SweetAlert2 to fade away.

I'm honored @limonte, thank you so much! I love this project, and I'll do my best! But be careful with 🚌 out there 😄

[gverni]

we should add those rules about spaces to our eslint config to enforce the coding style

@limonte, how about adding also:

• padded-block
• no-multi-spaces

I'm taking inspiration from https://github.com/standard/eslint-config-standard. We can also merge more settings from there (where we see fit). Let me know if you are in favor and I can open a PR for that.

[limonte]

I'm taking inspiration from https://github.com/standard/eslint-config-standard. We can also merge more settings from there (where we see fit). Let me know if you are in favor and I can open a PR for that.

Why not to extend it then instead of copy-pasting rules? #1643

[limonte]

🎉 This PR is included in version 8.13.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀