refactor: support for generic types in interfaces and methods #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for noticing that! Please go ahead with the PR and I'll release that as the patch version, because the change isn't breaking in terms of documented API. |
limonte
pushed a commit
that referenced
this pull request
May 28, 2020
## [9.13.2](v9.13.1...v9.13.2) (2020-05-28) ### Bug Fixes * **types:** support for generic types in interfaces and methods ([#1981](#1981)) ([146309c](146309c))
|
🎉 This PR is included in version 9.13.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
matvejs16
pushed a commit
to matvejs16/sweetalert2-fix
that referenced
this pull request
Mar 29, 2023
matvejs16
pushed a commit
to matvejs16/sweetalert2-fix
that referenced
this pull request
Mar 29, 2023
## [9.13.2](sweetalert2/sweetalert2@v9.13.1...v9.13.2) (2020-05-28) ### Bug Fixes * **types:** support for generic types in interfaces and methods ([sweetalert2#1981](sweetalert2#1981)) ([370f8c4](sweetalert2@370f8c4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically allow us to grab a typed
valueinSweetAlertResult.Btw when I was working on this I noticed there are some fixes to be made in this file which may cause breaking changes, like
function getContent(): HTMLElementwhere it should befunction getContent(): HTMLElement | nullas it could potentially returnnull(in fact, all classes that consumeselementBySelectorcould).sweetalert2/src/utils/dom/getters.js
Lines 7 to 10 in 38b5965
What's the policy for breaking changes in this declaration file, @limonte? Once you point me to the right direction I could go ahead and made the necessary changes :)