Better type declaration for inputAttributes

[toverux]

This is a PR to improve the type definition of the inputAttributes option, added recenlty by @Fkscorpion in #466.

First, in the aca4dc3 commit, I used a mapped type - to allow IDEs to provide auto-completion - in intersection with a standard dictionary, to allow custom attributes and not only HTMLInputElement's ones.

Then, I've decided to remove the mapped type and only keep the dictionary, since this is a bleeding-edge, TypeScript 2.1 feature, so it would break alot of consumers' applications without a single benefit from a static typing point of view (only IDE assistance, but even my IDE is not yet capable of understanding a type intersection with a mapped type, so...).

You'll note that the dictionary maps to string and not any, because setAttribute() (used under the hood in SweetAlert) takes a string, and not any value (the DOM API, however, takes typed values, but setAttribute() is an HTML thing).

Maybe I will make a new PR about adding a inputProperties option that sets HTMLInputElement DOM properties, and not HTML attributes. The DOM API is better to work with than the XML/HTML one, fits most use cases and offers a much better typed experience.

API proposal:

interface SweetAlertOptions {
    inputProperties?: Partial<HTMLInputElement>;

    // de-sugarified:
    inputProperties?: { [P in keyof HTMLInputElement]?: HTMLInputElement[P] };
}

[limonte]

Thanks a million @toverux for caring about the TypeScript support. You're the best here! Feel free to merge PRs related to TypeScript without waiting for approval from me :)

Btw, I just noticed that definitions of 2 parameters are missing:

• target which was introduced in https://github.com/limonte/sweetalert2/releases/tag/v6.4.2
• allowEnterKey which was introduced in https://github.com/limonte/sweetalert2/releases/tag/v6.4.1

Could you please handle them?

[toverux]

Thank you :)

Could you please handle them?

Of course, no problem!