[WIP] make the project executable #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's awesome!! |
|
There's some care to put into the dependencies, it seems a bit brittle; the code would crash with bokeh>=3, and it seems that pipx could not find the pinned version of essentia. With that said, last version seems to work with all versions >=3.8 of Python, including with pipx. |
|
Thank you for submitting your PR. I really appreciate the effort you have put into it. I will review it thoroughly and carefully once the Pop2Piano paper's review process is complete. |
|
Thank you and good luck with the paper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First: absolutely awesome project! Thank you very much for it.
This is a quick and dirty PoC (the features other than the generator are probably broken, I didn't fix all imports) move to have the generator be easily installable as a CLI program, that could eventually be posted to PyPI.