Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externalize hook script(s) in source with include_str! macro #49

Closed
calebcartwright opened this issue Jul 3, 2019 · 0 comments · Fixed by #53
Closed

Externalize hook script(s) in source with include_str! macro #49

calebcartwright opened this issue Jul 3, 2019 · 0 comments · Fixed by #53
Assignees
@calebcartwright
Labels
done Work on the Issue or PR is completed good first issue Good for newcomers
Projects
1.0 Release
Milestone
1.0 Release

Comments

@calebcartwright
Copy link
Member

The git hook script is currently defined inline in a Rust file, but it would be a bit easier to view/manage/etc. if we extract it into a separate .sh file and use include_str!(...) to pull the contents in at compile time. Plus this would also let us run tools like ShellCheck against the scripts

https://doc.rust-lang.org/std/macro.include_str.html
calebcartwright added a commit that referenced this issue Jul 10, 2019
@calebcartwright
refactor: externalize hook script, refs #49
7dac6a0
@calebcartwright calebcartwright mentioned this issue Jul 10, 2019
Merged
3 tasks
@calebcartwright calebcartwright self-assigned this Jul 11, 2019
@calebcartwright calebcartwright added good first issue Good for newcomers WIP Work is in progress done Work on the Issue or PR is completed and removed WIP Work is in progress labels Jul 11, 2019
@calebcartwright calebcartwright added this to To do in 1.0 Release via automation Jul 11, 2019
@calebcartwright calebcartwright added this to the 1.x Release milestone Jul 11, 2019
@calebcartwright calebcartwright moved this from To do to In progress in 1.0 Release Jul 11, 2019
1.0 Release automation moved this from In progress to Done Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calebcartwright calebcartwright

Labels
done Work on the Issue or PR is completed good first issue Good for newcomers
Projects
1.0 Release
  
Done
Milestone
1.0 Release
Development

Successfully merging a pull request may close this issue.

feat: improve behavior when config file is missing swellaby/rusty-hook
1 participant
@calebcartwright