Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate code not required. #8

Closed
keithmifsud opened this issue May 15, 2018 · 0 comments
Closed

Duplicate code not required. #8

keithmifsud opened this issue May 15, 2018 · 0 comments
Assignees
@keithmifsud
Labels
code improvement
Projects
Development of Admiral
Milestone
Release of Versio...

Comments

@keithmifsud
Copy link
Contributor

admiral/src/Admiral/ArrayResolver.php

Line 69 in b839c30

$handler = new $handler(...$dependencies);

@keithmifsud keithmifsud added this to the Release of Version 1.0 milestone May 15, 2018
@keithmifsud keithmifsud self-assigned this May 15, 2018
@keithmifsud keithmifsud added this to To Do in Development of Admiral via automation May 15, 2018
@keithmifsud keithmifsud moved this from To Do to In progress in Development of Admiral May 15, 2018
keithmifsud added a commit to keithmifsud/admiral that referenced this issue May 15, 2018
@keithmifsud
swellphpGH-8 Fixed duplicate line of code as it was needed.
f8a78af
keithmifsud added a commit that referenced this issue May 15, 2018
@keithmifsud
Merge pull request #9 from keithmifsud/GH-8
98478d5 
GH-8 Fixed duplicate line of code as it was needed.
Development of Admiral automation moved this from In progress to Done May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithmifsud keithmifsud

Labels
code improvement
Projects
Development of Admiral
  
Done
Milestone
Release of Version 1.0
Development

No branches or pull requests
1 participant
@keithmifsud