Fix path for running tests #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swengorschewski Hi there, could you merge this please? We've recently created one of our projects using this module and are currently unable to get our tests working due to this bug. Thanks |
|
@zetaron FYI it's possible to add electron support on top of react-scripts-ts, which this is based on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change of the appSrc path from 'src' to 'src/app' causes 'yarn test' to fail to find any tests as resolves the <rootDir> to the parent of appSrc and then searches in <rootDir>/src for tests, which resolves to 'src/src', this PR fixes this to take two parents from appSrc.
The bug is easily verified by creating a fresh app using: create-react-app electron-vanilla-app --scripts-version=react-scripts-ts-electron
and running 'yarn test'
btw, this has been a incredibly useful starter for my Electron/Typescript/React app, thanks for the great work @swengorschewski