8275535: Retrying a failed authentication on multiple LDAP servers ca…

…n lead to users blocked Reviewed-by: aefimov, dfuchs
swesonga · May 12, 2022 · 3be394e · 3be394e
1 parent cc7560e
commit 3be394e
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/java.naming/share/classes/com/sun/jndi/ldap/LdapCtxFactory.java b/src/java.naming/share/classes/com/sun/jndi/ldap/LdapCtxFactory.java
@@ -189,6 +189,10 @@ private static DirContext getUsingURL(String url, Hashtable<?,?> env)
                     ctx = getLdapCtxFromUrl(
                             r.getDomainName(), url, new LdapURL(u), env);
                     return ctx;
+                } catch (AuthenticationException e) {
+                    // do not retry on a different endpoint to avoid blocking
+                    // the user if authentication credentials are wrong.
+                    throw e;
                 } catch (NamingException e) {
                     // try the next element
                     lastException = e;
@@ -241,6 +245,10 @@ private static DirContext getUsingURLs(String[] urls, Hashtable<?,?> env)
         for (String u : urls) {
             try {
                 return getUsingURL(u, env);
+            } catch (AuthenticationException e) {
+                // do not retry on a different URL to avoid blocking
+                // the user if authentication credentials are wrong.
+                throw e;
             } catch (NamingException e) {
                 ex = e;
             }