Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Compatability #12

Open
sweverett opened this issue Mar 7, 2017 · 5 comments
Open

Python 3 Compatability #12

sweverett opened this issue Mar 7, 2017 · 5 comments
Assignees
Milestone

Comments

@sweverett
Copy link
Owner

We should probably convert everything to be Python 3 compatible, just to be forward looking :)

@sweverett sweverett added this to the Spring Quarter milestone Mar 7, 2017
@sweverett sweverett self-assigned this Mar 7, 2017
@sweverett sweverett assigned paigemkelly and unassigned sweverett Feb 11, 2020
@sweverett sweverett modified the milestones: Spring Quarter, Someday Feb 11, 2020
@sweverett
Copy link
Owner Author

Re-emphasizing this now that we live in a post Python-2 world! We should write the clustr rewrite completely in Python 3 now that Python 2 is dead, RIP.

@jjobel
Copy link
Collaborator

jjobel commented Sep 25, 2020

Now that we've closed issue #39, can I go ahead and tackle this issue. Last week I was running clustr on python 3 just fine but now that I created a new clustr environment with python 2 I'm wondering if I should jump back on to python 3 (along with updated libraries)? It seems like there's a small amount of changes that need to done on clustr.py.

@jjobel jjobel self-assigned this Sep 25, 2020
@jjobel
Copy link
Collaborator

jjobel commented Sep 25, 2020

Just ran the code in python 3 and it works fine.

@sweverett
Copy link
Owner Author

If linmix is behaving with python3, then no reason to stay with 2. My main concern was with rpy2, but we no longer need that package since we are sticking with the Kelly method.

@jjobel
Copy link
Collaborator

jjobel commented Sep 25, 2020

Okay awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants