Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kusaでStreakの数値が-1になる #547

Closed
swfz opened this issue Jul 1, 2023 · 2 comments · Fixed by #551, #557 or #578
Closed

kusaでStreakの数値が-1になる #547

swfz opened this issue Jul 1, 2023 · 2 comments · Fixed by #551, #557 or #578
Assignees
@swfz

Comments

@swfz
Copy link
Owner

swfz commented Jul 1, 2023 •
edited

  • 1年以上継続して草を生やした場合、APIから取得できるデータに0が含まれなくなるので-1になる
  • APIの見直しから考える必要がある

image
@swfz swfz linked a pull request Jul 4, 2023 that will close this issue
fix: 365日以上のstreakの場合の文言を設定 #551
Merged
@swfz swfz closed this as completed in #551 Jul 4, 2023
@swfz swfz reopened this Jul 4, 2023
swfz added a commit that referenced this issue Jul 6, 2023
@swfz
feat: #547 fetch contributions recursively
92cc971
@swfz swfz mentioned this issue Jul 6, 2023
Merged
@swfz swfz linked a pull request Jul 6, 2023 that will close this issue
feat: #547 fetch contributions recursively #557
Merged
@swfz
Copy link
Owner Author

swfz commented Jul 6, 2023

現在使用しているAPIでは直近以外のcontributionを取得できなかったためforkしてtoパラメータを送れる用に変更してデプロイした
そして暫定的に変更したAPIを叩くようにした

https://forked-gh-contributions.deno.dev/

@swfz swfz closed this as completed in #557 Jul 6, 2023
swfz added a commit that referenced this issue Jul 6, 2023
@swfz
Merge pull request #557 from swfz/feature/change-contribution-count-api
753d3d0 
feat: #547 fetch contributions recursively
@github-actions github-actions bot mentioned this issue Jul 6, 2023
Open
@swfz swfz reopened this Jul 6, 2023
@swfz swfz linked a pull request Jul 24, 2023 that will close this issue
Contribution APIのURLを変更 #578
Merged
@swfz swfz closed this as completed in #578 Jul 24, 2023
@swfz
Copy link
Owner Author

swfz commented Jul 24, 2023

大本にPR出してMergeしてもらったので #578 でもとに戻した

@swfz swfz self-assigned this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swfz swfz

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@swfz