Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build #3

Merged
merged 2 commits into from Jun 16, 2017
Merged

fix build #3

merged 2 commits into from Jun 16, 2017

Conversation

kroll-j
Copy link
Contributor

@kroll-j kroll-j commented Jun 15, 2017

Project wouldn't build because -lm is missing on linker command line. This fixes it :)

@kroll-j
Copy link
Contributor Author

kroll-j commented Jun 15, 2017

Add FLAC format support

@@ -13,6 +13,7 @@ AC_HEADER_STDC
PKG_CHECK_MODULES(GTK, [gtk+-2.0 >= 2.0.0])
PKG_CHECK_MODULES(JACK, [jack >= 0.80.0])
PKG_CHECK_MODULES(LIBLO, liblo >= 0.24, LO_FOUND="yes", LO_FOUND="no")
AC_CHECK_LIB([m],[pow])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which compiler/platform are you using to build? It's currently warking as-is on nixos
https://github.com/NixOS/nixpkgs/blob/56904d7c423f2b13b37fbd29f39bbb4b52bc7824/pkgs/applications/audio/timemachine/default.nix

Copy link
Contributor Author

@kroll-j kroll-j Jun 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc 5.4.0 on Mint 18 x86_64. john-d-murphy ran into the same issue before: https://github.com/john-d-murphy/timemachine/commit/9df5565935af697306bb664afa0085d829837d51#diff-3b3a6ec97232deb43dc14319a73872c1

Linking to the math library is necessary if you use math functions. If it happens to work on your system without -lm, maybe because the compiler is inlining all of them, it's only a fluke.

@swh swh merged commit 5cfbbad into swh:master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants