Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RED metrics recording #245

Merged
merged 2 commits into from May 13, 2020
Merged

Implement RED metrics recording #245

merged 2 commits into from May 13, 2020

Conversation

adam-fowler
Copy link
Member

Using swift-metrics
Metrics also record AWS service and operation
I've verified this works using SwiftPrometheus

Using swift-metrics
Metrics also record AWS service and operation
@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #245 into master will increase coverage by 2.59%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   68.31%   70.91%   +2.59%     
==========================================
  Files          38       44       +6     
  Lines        4002     5140    +1138     
==========================================
+ Hits         2734     3645     +911     
- Misses       1268     1495     +227     
Impacted Files Coverage Δ
Sources/AWSSDKSwiftCore/AWSClient.swift 91.90% <96.29%> (+2.80%) ⬆️
Sources/AWSSDKSwiftCore/ServiceConfig.swift 93.33% <100.00%> (+0.22%) ⬆️
Sources/AWSSDKSwiftCore/Doc/Region.swift 95.16% <0.00%> (-2.74%) ⬇️
Sources/AWSSDKSwiftCore/Doc/AWSShape.swift 83.05% <0.00%> (-1.74%) ⬇️
Sources/AWSSDKSwiftCore/XML.swift 83.58% <0.00%> (-0.11%) ⬇️
...ources/AWSSDKSwiftCore/Doc/AWSMemberEncoding.swift 100.00% <0.00%> (ø)
Sources/AWSSDKSwiftCore/Errors/ClientErrors.swift 53.33% <0.00%> (ø)
...ore/Encoder/CodableProperties/TimeStampCoder.swift 77.27% <0.00%> (ø)
.../Encoder/CodableProperties/CodableProperties.swift 83.87% <0.00%> (ø)
...e/Encoder/CodableProperties/CollectionCoders.swift 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f672e1f...2695536. Read the comment docs.

@adam-fowler adam-fowler added this to In progress in v5.0.0 via automation May 12, 2020
@adam-fowler adam-fowler added this to the 5.0.0 milestone May 12, 2020
Copy link
Member

@Yasumoto Yasumoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely optional metric renames, but this looks excellent!

Renamed metrics to aws_request_total and aws_request_errors

Co-authored-by: Joe Smith <yasumoto7@gmail.com>
@adam-fowler
Copy link
Member Author

Definitely optional metric renames, but this looks excellent!

Happy with the metric renames and see the logic with same prefix

Copy link
Member

@Yasumoto Yasumoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@adam-fowler adam-fowler merged commit 4130949 into master May 13, 2020
v5.0.0 automation moved this from In progress to Done May 13, 2020
@adam-fowler adam-fowler deleted the swift-metrics branch May 13, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants