New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RED metrics recording #245
Conversation
Using swift-metrics Metrics also record AWS service and operation
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 68.31% 70.91% +2.59%
==========================================
Files 38 44 +6
Lines 4002 5140 +1138
==========================================
+ Hits 2734 3645 +911
- Misses 1268 1495 +227
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely optional metric renames, but this looks excellent!
Renamed metrics to aws_request_total and aws_request_errors Co-authored-by: Joe Smith <yasumoto7@gmail.com>
Happy with the metric renames and see the logic with same prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Using swift-metrics
Metrics also record AWS service and operation
I've verified this works using SwiftPrometheus