Fixed issue where decoding of empty bytes crashed. (#27)

swift-extras · Feb 12, 2021 · 9c7648c · 9c7648c
1 parent f68105b
commit 9c7648c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/Sources/ExtrasBase64/Chromium.swift b/Sources/ExtrasBase64/Chromium.swift
@@ -329,6 +329,10 @@ extension Base64 {
 
     @inlinable
     public static func decode<Buffer: Collection>(bytes: Buffer, options: DecodingOptions = []) throws -> [UInt8] where Buffer.Element == UInt8 {
+        guard bytes.count > 0 else {
+            return []
+        }
+
         let decoded = try bytes.withContiguousStorageIfAvailable { (input) -> [UInt8] in
             let outputLength = ((input.count + 3) / 4) * 3
 

diff --git a/Tests/ExtrasBase64Tests/ChromiumTests.swift b/Tests/ExtrasBase64Tests/ChromiumTests.swift
@@ -42,6 +42,12 @@ class ChromiumTests: XCTestCase {
         XCTAssertEqual(decoded?.count, 0)
     }
 
+    func testDecodeEmptyBytes() throws {
+        var decoded: [UInt8]?
+        XCTAssertNoThrow(decoded = try Base64.decode(bytes: []))
+        XCTAssertEqual(decoded?.count, 0)
+    }
+
     func testBase64DecodingArrayOfNulls() throws {
         let expected = Array(repeating: UInt8(0), count: 10)
         var decoded: [UInt8]?