Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support padding characters in base32 #32

Merged
merged 14 commits into from
May 13, 2024

Conversation

adam-fowler
Copy link
Collaborator

@adam-fowler adam-fowler commented May 12, 2024

Also

  • optimize Base32._encode
  • Update CI. Remove a bunch of unnecessary CI, update for latest swift versions, update code coverage upload
  • Removed LinuxMain.swift

@adam-fowler adam-fowler changed the title Add .vscode to .gitignore support padding characters in base32 May 12, 2024
Get rid of Xcode build tests and just use SwiftPM, reduce number of tests as many are unnecessary
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 97.97980% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.84%. Comparing base (97237cf) to head (2b56a06).

Files Patch % Lines
Sources/ExtrasBase64/Base32.swift 97.70% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   91.66%   90.84%   -0.82%     
==========================================
  Files           2        2              
  Lines         276      306      +30     
==========================================
+ Hits          253      278      +25     
- Misses         23       28       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit about the CI, otherwise looks good

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@gwynne gwynne merged commit 188c596 into swift-extras:main May 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants