Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename encodeBytes to encodeToBytes, encodeString to encodeToString #33

Merged
merged 1 commit into from
May 13, 2024

Conversation

adam-fowler
Copy link
Collaborator

Makes it clearer what the Bytes and String mean in the function name

@adam-fowler adam-fowler requested a review from gwynne May 13, 2024 08:16
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 89.86%. Comparing base (97237cf) to head (3c869cf).
Report is 1 commits behind head on main.

Files Patch % Lines
Sources/ExtrasBase64/Base64.swift 0.00% 4 Missing ⚠️
Sources/ExtrasBase64/Base32.swift 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   91.66%   89.86%   -1.80%     
==========================================
  Files           2        2              
  Lines         276      306      +30     
==========================================
+ Hits          253      275      +22     
- Misses         23       31       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-fowler adam-fowler mentioned this pull request May 13, 2024
@adam-fowler adam-fowler merged commit 1e8b1cc into swift-extras:main May 13, 2024
9 of 11 checks passed
@adam-fowler adam-fowler deleted the encode-to branch May 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants