Easier to read lookup table for encoding using UInt8(ascii: "A") #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 4 4
Lines 258 258
=======================================
Hits 252 252
Misses 6 6
Continue to review full report at Codecov.
|
As proposed in by @weissi in apple/swift-nio#1322 replacing the encode lookup table with uses of `UInt8(ascii: “A”)` instead of `65` for better to read code.
fabianfett
force-pushed
the
feature/better-to-read-lookup-table
branch
from
183d89c
to
b448b8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in by @weissi in apple/swift-nio#1322
replacing the encode lookup table with uses of
UInt8(ascii: “A”)instead of65for better to read code.