Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBP pickle framer might be stripping #113

Closed
mookerji opened this issue Apr 15, 2015 · 0 comments
Closed

SBP pickle framer might be stripping #113

mookerji opened this issue Apr 15, 2015 · 0 comments
Labels
bug

Comments

@mookerji
Copy link
Contributor

I noticed this earlier with construct's CString object, where the payload string parsed from SBP seems to be missing the null termination character in the handshake value for the MsgBootloaderHandshake. As such, the parsing of this field can fail if it's not actually NULL terminated.
@mookerji mookerji added the bug label Apr 15, 2015
fnoble added a commit to fnoble/libsbp that referenced this issue Apr 15, 2015
@fnoble
SPEC: Bootloader version string is not null terminated
3eb0b72 
This was causing construct's Cstring parser to fail (as it should have). This fix is to just treat it as a byte array.

Fixes swift-nav#113
@fnoble fnoble mentioned this issue Apr 15, 2015
Merged
@fnoble fnoble closed this as completed in 4cfbc2d Apr 16, 2015
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this issue May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mookerji