Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootload test fixes (and more!) #117

Merged
merged 3 commits into from
Apr 16, 2015
Merged

Bootload test fixes (and more!) #117

merged 3 commits into from
Apr 16, 2015

Conversation

fnoble
Copy link
Contributor

@fnoble fnoble commented Apr 16, 2015

  • Some generalization of the generator to properly handle arrays of primitive types
  • Fix to bootloader test now we have a new payload spec (from Misc Fixes #114)

@fnoble
GENERATOR: Recursively calculate formats for array contents
75f6f51 
Allows us to represent arrays of primitive types as well as structs.
@fnoble
Generalize walk_json_dict
78de46b 
No reason we should only have lists of dicts!
@fnoble
Fix bootload test
9ce4660
@fnoble
Copy link
Contributor Author

fnoble commented Apr 16, 2015

@mfine @mookerji

@swiftnav-jenkins
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/48/
Test FAILed.

@fnoble
Copy link
Contributor Author

fnoble commented Apr 16, 2015

retest this please

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/49/
Test PASSed.

mookerji
mookerji reviewed Apr 16, 2015
View reviewed changes
spec/tests/yaml/swiftnav/sbp/test_bootload.yaml
@@ -6,11 +6,20 @@ tests:

- msg:
fields:
handshake: 118
handshake: [118, 49, 46, 50] # 'v1.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I suppose this is fine for the time being. It's more a problem that we aren't being consistent with our schema (null terminated strings). I'll probably follow up at some point with making this parser conditional.

mookerji added a commit that referenced this pull request Apr 16, 2015
@mookerji
Merge pull request #117 from fnoble/bootload_test_fix
d47459b 
Bootload test fixes (and more!)
@mookerji mookerji merged commit d47459b into swift-nav:master Apr 16, 2015
@fnoble fnoble deleted the bootload_test_fix branch April 20, 2015 16:13
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Jun 24, 2022
Merged
silverjam pushed a commit that referenced this pull request Jun 24, 2022
@swiftnav-svc-jenkins
Auto submodule update: cmake - Add Module For Checking Atomic (#117) (#…
d5fcace 
…1171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fnoble @swiftnav-jenkins @mookerji