Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SBP fields when materializing child objects. #130

Merged
merged 1 commit into from
Apr 23, 2015
Merged

Update SBP fields when materializing child objects. #130

merged 1 commit into from
Apr 23, 2015

Conversation

mookerji
Copy link
Contributor

Oh joy! Apparently, instantiating an SBP message and then attempting
to serialize results in an error from the parent SBP object, which
hasn't been backfilled (crc, etc.). This adds an __update call to
children objects to update these fields.

/cc @fnoble @mfine

@mookerji mookerji added the bug label Apr 22, 2015
@mookerji mookerji self-assigned this Apr 22, 2015
@swiftnav-jenkins
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/66/
Test FAILed.

@mookerji
Copy link
Contributor Author

retest this please

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/67/
Test PASSed.

@mookerji
Copy link
Contributor Author

Found this while writing a unit test last night, do not merge yet.

@swiftnav-jenkins
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/68/
Test FAILed.

@mookerji
Copy link
Contributor Author

retest this please

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/69/
Test PASSed.

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/70/
Test PASSed.

@mookerji
Copy link
Contributor Author

k, this is ready to go whenever.

mfine
mfine reviewed Apr 22, 2015
View reviewed changes
generator/sbpg/targets/resources/sbp_construct_template.py.j2
@@ -130,6 +135,12 @@ class ((( m.identifier | classnameify )))(SBP):
def __repr__(self):
return fmt_repr(self)
((* if m.fields *))

def __update(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this just be to_binary(self)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@mfine
Copy link
Contributor

mfine commented Apr 22, 2015

Looks good. It's increasingly difficult to navigate the serialization/deserialization paths here, but the external interface looks stable and good.

@swiftnav-jenkins
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/72/
Test FAILed.

@mookerji
Update SBP fields when materializing child objects.
a430fcf 
Oh joy! Apparently, instantiating an SBP message and then attempting
to serialize results in an error from the parent SBP object, which
hasn't been backfilled (crc, etc.). This adds an __update call to
children objects to update these fields.

Came up while writing some inline logs for unit testing a new
sbp_log_analysis test.

/cc @fnoble @mfine
@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/73/
Test PASSed.

mookerji added a commit that referenced this pull request Apr 23, 2015
@mookerji
Merge pull request #130 from mookerji/fix-materialization
a7c1ee6 
Update SBP fields when materializing child objects.
@mookerji mookerji merged commit a7c1ee6 into swift-nav:master Apr 23, 2015
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Aug 30, 2022
Merged
silverjam pushed a commit that referenced this pull request Aug 30, 2022
@swiftnav-svc-jenkins
Auto submodule update: cmake - compile compile command cleanup (#130) (…
b56f6d1 
…#1215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mookerji mookerji

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mookerji @swiftnav-jenkins @mfine