Allow the logger to inject tags into the logs #145
Conversation
|
Test PASSed. |
| return {"delta": self.delta(), | ||
| "timestamp": self.timestamp(), | ||
| "data": data} | ||
| msg = {"delta": self.delta(), "timestamp": self.timestamp(), "data": data} |
There was a problem hiding this comment.
Hmmm, I think there's a risk here of tags stamping over some existing keys (delta, timestamp, data).
There was a problem hiding this comment.
I agree with your nesting suggestion, probably having something like 'tags' with msg = {"delta": self.delta(), "tags": .}
There was a problem hiding this comment.
Yeah, I actually reversed it - but then thought that might be desirable to overwrite. But probably not.
There was a problem hiding this comment.
Added a metadata field, and always populate it, even if empty. tags is a little arbitrary - metadata fits nicer with data. Potentially header could be used here, too.
|
Test PASSed. |
Allow the logger to inject tags into the logs
Add a tags parameter to Base logger and use it in JSON logger. It's a string of tags separated by commas used to decorate the logs with. This results in something like:
generates:
{"timestamp": 1431022699, "WUT": "now", "HI": "hater", "data": ...This will be used to inject session data into the logs, namely
session_id. There's some questions here on whether to nest these tags and metadata - we can update that as necessary./cc @mookerji