libsbp python bindings. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| from construct import * | ||
| from swift.sbp import SBP | ||
| from swift.sbp.utils import fmt_repr |
There was a problem hiding this comment.
Is this import swift.sbp right? Or is it swiftnav.sbp?
There was a problem hiding this comment.
uh, that's a typo. actually a really weird one.....
|
Generated bindings are looking good! |
| # EITHER EXPRESSED OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE IMPLIED | ||
| # WARRANTIES OF MERCHANTABILITY AND/OR FITNESS FOR A PARTICULAR PURPOSE. | ||
|
|
||
| """Utility functions for shared |
|
This is looking great! Still some formatting issues with the output when comment lines wrap 80 cols but functionally looks good (although didn't test myself yet). |
| crc = data['crc'] | ||
| return SBP(msg_type, sender, length, payload, crc) | ||
|
|
||
| def to_json_dict(self): |
There was a problem hiding this comment.
wow, i'm troubled that this wasn't caught (by python)
|
Only caught a minor indent issue. Looking good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsbp python bindings using Construct, a declarative binary parsing
library for Python. Following up with a separate PR for a test
harness.
/cc @mfine, @fnoble, @imh