libsbp C headers and test stubs. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mookerji
added
1 - Spring Backlog
Language Distribution
and removed
1 - Spring Backlog
labels
| #define SBP_MSG_OBS 0x0045 | ||
| typedef struct __attribute__((packed)) { | ||
| observation_header_t header; /**< Header of a GPS observation message */ | ||
| packed_obs_content_t* obs; /**< Observations */ |
There was a problem hiding this comment.
This is incorrect because pointers and arrays are not really the same. You can do something similar to this but unfortunately in C you can only express a variable length array if it is the last element of the struct (google C99 flexible array member) :(
We should probably think hard about how to deal with these kinds of constructs.
|
Looks good, a few thoughts:
|
First pass at libsbp C headers for inclusion in libswiftnav and piksi_firmware. Will fix formatting issues later, but need comments for integration, etc. /cc @fnoble
In the rare instances we're using variable-length arrays, use a 0-length array. It seems we can't use the C99 flexible array declaration in the case where the flexible array is the only element in the struct.
|
An update:
|
|
Mark Twain |
mookerji
added a commit
that referenced
this pull request
Mar 19, 2015
libsbp C headers and test stubs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at libsbp C headers for inclusion in libswiftnav and
piksi_firmware. Will fix formatting issues later, but need comments
for integration, etc.
/cc @fnoble @gsmcmullin @mfine @cbeighley