Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML-specified SBP deserialization unit tests and Python test harness. #52

Merged
merged 2 commits into from
Mar 26, 2015
Merged

YAML-specified SBP deserialization unit tests and Python test harness. #52

merged 2 commits into from
Mar 26, 2015

Conversation

mookerji
Copy link
Contributor

Defines unit test coverage for SBP messages. The idea here is that
this single unit test specification can be shared by any language
implementing an SBP client.

/cc @mfine @fnoble @imh

# WARRANTIES OF MERCHANTABILITY AND/OR FITNESS FOR A PARTICULAR PURPOSE.

"""
Command line utility for reading an SBP log and generating somes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: somes

@mookerji
Copy link
Contributor Author

@mfine @fnoble @imh This is basically ready to go.

Defines unit test coverage for SBP messages. The idea here is that
this single unit test specification can be shared by any language
implementing an SBP client.

/cc @mfine @fnoble
#
# THIS CODE AND INFORMATION IS PROVIDED "AS IS" WITHOUT WARRANTY OF ANY KIND,
# EITHER EXPRESSED OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE IMPLIED
# WARRANTIES OF MERCHANTABILITY AND/OR FITNESS FOR A PARTICULAR PURPOSE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty? Is this because nothing gets generated for the SBP definition? Should we just filter file generation out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I think so. Any of the SBP constructor code gets exercised by the rest of the tests.

@mfine
Copy link
Contributor

mfine commented Mar 25, 2015

This is looking good to me - couple of nits and questions.

mookerji added a commit that referenced this pull request Mar 26, 2015
YAML-specified SBP deserialization unit tests and Python test harness.
@mookerji mookerji merged commit 61e6b2a into swift-nav:master Mar 26, 2015
@mookerji mookerji removed the 5 - Done label Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants