Examples for Python client library #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So examples work inside package or standalone.
|
|
||
| with PySerialDriver(args.serial_port[0], args.baud[0]) as driver: | ||
| with Handler(driver.read, driver.write) as handler: | ||
| udp = socket.socket(socket.AF_INET, socket.SOCK_DGRAM) |
There was a problem hiding this comment.
Maybe throw the socket in a with statement?
with socket.socket(socket.AF_INET, socket.SOCK_DGRAM) as udp... but nevermind, because python sockets don't implement context manager apparently. Might be good to have a close on the socket just to be proper.
There was a problem hiding this comment.
Hehe, I tried that first too. I like this method mentioned in the SO thread:
from contextlib import closing
import socket
with closing(socket.socket()) as s:
print s
sound good?
|
Looks good to me! |
|
Looking. |
| args = parser.parse_args() | ||
|
|
||
| # Open a connection to Piksi using the default baud rate (1Mbaud) | ||
| with PySerialDriver(args.port[0], 1000000) as driver: |
There was a problem hiding this comment.
nit: baud_rate = 1000000.
|
just a few nits. otherwise fine to merge. |
fnoble
added a commit
that referenced
this pull request
Mar 24, 2015
Examples for Python client library
swiftnav-svc-jenkins
pushed a commit
that referenced
this pull request
May 6, 2020
IsakTjernberg
pushed a commit
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of how we may want to incorporate examples using the python client library.
Adds two examples:
In this case I needed something to send SBP over UDB so it can be fed into MAVProxy and eventually make its way into the telemetry stream up to a ArduPilot quadcopter (so we can use just one pair of radios for corrections and telemetry).