Change ssr_update_interval to u8. #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@silverjam - can you help me with the autogenerated code again? Did you ever manage to dockerize that? |
benjamin0
approved these changes
Jun 20, 2019
silverjam
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
@martin-swift pushed generated code, no dockerization yet, maybe a few more requests to generate code manually will do it 🤣
|
@martin-swift looks good to me. Only other improvement I can think of (but not really critical) is you could use GpsTimeSec instead of GpsTime, the former has whole second resolution latter has nanosecond resolution, I noticed our other SSR messages only use the second resolution type. |
ljbade
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.