SSR STEC and gridded correction message refinements #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| message to get the state space representation of the atmospheric | ||
| delay. | ||
| delay. It is typically equivalent to the QZSS CLAS Sub Type 8 messages |
There was a problem hiding this comment.
I wanted to put a reference to the CLAS message since you have to use the correction algorithm from that document. This way someone not familiar will know where to go find the details
spec/yaml/swiftnav/sbp/ssr.yaml
Outdated
| - MSG_SSR_STEC_CORRECTION: | ||
| id: 0x05EB | ||
| short_desc: Slant Total Electron Content | ||
| desc: | | ||
| The STEC per space vehicle, given as polynomial approximation for | ||
| a given grid. This should be combined with SSR-GriddedCorrection | ||
| a given grid area. This should be combined with MSG_SSR_GRIDDED_CORRECTION |
There was a problem hiding this comment.
not sure why we need "area". We have a grid that has been defined. Of course a grid covers an area; I feel like this is tautological and thus more confusing.
There was a problem hiding this comment.
sure i can drop that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further refinements to the SSR STEC and gridded correction messages for consistency with the existing SSR messages.
I also fleshed out the description and unit fields to make it easier for someone to use the messages without having to cross reference back to the CLAS spec.