Add timeout option if connection does not receive response. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@madsodgaard thank you so much, this is tremendously helpful. |
|
wow thank you. We were having this same issue, restarting the server like every 30 min is not fun, thanks for this. Any ideas as to why apple may not be returning anything? |
|
I'd like to give this a +100. Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a work-around for when Apple servers does not return any response, and therefore leaves the connection occupied and blocked. This means in production environments, with 2 connections you are forced to restart the server, if two attempts to send a push notifications hangs because of Apple. This actually happens pretty frequently.
The timeout is disabled by default and can be enabled by setting the
timeoutproperty ofAPNSwiftConfiguration.I've tested this in our production environment, and fixes the issues we were having with the connections blocking.