Repair MQTTClient.v5.unsubscribe to use properties arg #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new/empty properties was being put into the unsubscribe packet instead of the user-provided properties argument. Although there are not any nominal properties that would be used with unsubscribe packets, it is possible that user-defined properties could have vendor-specific meaning for certain MQTT brokers. [1] [1]: https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901182 Signed-off-by: Peter Grayson <pete@jpgrayson.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 79.04% 78.92% -0.13%
==========================================
Files 22 22
Lines 2500 2500
==========================================
- Hits 1976 1973 -3
- Misses 524 527 +3 ☔ View full report in Codecov by Sentry. |
|
Good catch |
adam-fowler
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new/empty properties was being put into the unsubscribe packet instead of the user-provided properties argument.
Although there are not any nominal properties that would be used with unsubscribe packets, it is possible that user-defined properties could have vendor-specific meaning for certain MQTT brokers. 1