Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Drop HTTPServing #85

Merged
merged 3 commits into from Nov 10, 2017
Merged

Conversation

helje5
Copy link
Contributor

@helje5 helje5 commented Nov 5, 2017

The API is concrete, this protocol serves no purpose.

The API is concrete, this protocol serves no purpose.
@seabaylea
Copy link
Member

seabaylea commented Nov 7, 2017

Yeah, I think the original reason was to separate the PoC Server implementation from the HTTP API layer, but as the server implementation doesn't leak out we can change it the future without affecting the API.

Unfortunately there's now a merge conflict - if you don't mind updating we'll get this in.

@carlbrown
Copy link
Contributor

@helje5 Will this still be relevant after #96 gets completed?

@helje5
Copy link
Contributor Author

helje5 commented Nov 10, 2017

This is distinct to #96, that still has it (I tried not to change too many things). And who knows whether #96 is actually going to be used. Even if not, we should drop HTTPServing anyways. (just my opinion, it is certainly not me who decides such stuff ...)

@carlbrown
Copy link
Contributor

Resolved the merge conflict - waiting on the CI run

@carlbrown carlbrown merged commit 397c5fb into swift-server:develop Nov 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants