New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.MD SimpleLambdaHandler example with events. #286

Merged

tomerd merged 2 commits into swift-server:main from fitomad:main

Feb 9, 2023

Contributor

fitomad commented Feb 9, 2023

Changed the SQS.Event type to the existing SQSEvent type

Motivation:

Try to run the mentioned code snippet throws a non existing type error.

Because the AWS events are developed in a separated package could takes some times to find the error to a developer trying to use this snippet as base for his/her code.

Also, the Void returning type has been removed from code, following the Apple style guideline related to the use of Void.

Modifications:

At README.MD file, change the snippet to use the right type and Void returning type removed to follow the Apple style guideline.

Result:

The snippet

 // Import the modules
 import AWSLambdaRuntime
 import AWSLambdaEvents

 @main
 struct MyLambda: SimpleLambdaHandler {
     // In this example we are receiving a SQS Event, with no response (Void).
     func handle(_ event: SQSEvent, context: LambdaContext) async throws {
         ...
     }
 }

fitomad and others added 2 commits

February 9, 2023 09:01


          Change the SQS.Event to the valid SQSEvent type at the SimpleLambdaHa…

5bc4143

…ndler example


          Merge pull request #1 from fitomad/readme-sqsevent-example

08df087

Change the SQS.Event to the valid SQSEvent type

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

12 similar comments

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

swift-server-bot commented Feb 9, 2023

Can one of the admins verify this patch?

Contributor

tomerd commented Feb 9, 2023

@swift-server-bot test this please

Contributor

tomerd commented Feb 9, 2023

thanks @fitomad

tomerd approved these changes

View reviewed changes

tomerd enabled auto-merge (squash)

February 9, 2023 08:17

fitomad mentioned this pull request

README.MD example about SimpleLambdaHandler #285

Closed

tomerd merged commit 81762b0 into swift-server:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment